Repository navigation
Conversation
- ShippingPolicy.spec.ts asserted a 50/5.99 threshold that stopped matching the real
300/25 constants a while ago (4 failing tests). Rewrote it to read the expected values
off ShippingPolicy's own constants instead of duplicating them, so it can't go stale
the same way again
- delete the empty, committed value-objects/__spec__/Product.spec.ts, superseded by the
one under value-objects/Product/
- Product.spec.ts gave beginner/adventurer/expert the exact same ProfileDetails, so the
level-routing logic was never actually exercised. Gave each level distinct data,
which is what caught Product.getLoreLink/getVideoUrl having three branches that all
returned the same expression
- LocalStorageWelcomeSurveyRepository.getSurvey() could never read localStorage: cache
was initialized to {survey: null}, so the `cache !== undefined` guard always won.
Fixed the sentinel and added the coverage this repository never had
- TanstackStoreWelcomeSurvey.repository.ts touched localStorage at import time with no
guard, which would crash under a Node server-side render (the prerender step lands
later in this stack). Guarded both accesses, added a node-environment spec proving the
module now imports and works without a DOM
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014BcGPRc3sgUJYKihGRXh5g
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5. This is the one that turns the Test job green.
Summary
ShippingPolicy.spec.tsasserted a 50/5.99 threshold that stopped matching the real300/25 constants a while ago. Rewrote it to read the expected values off
ShippingPolicy's own constants instead of duplicating them, so it can't drift againvalue-objects/__spec__/Product.spec.ts, superseded by theone under
value-objects/Product/Product.spec.tsgave beginner, adventurer, and expert the exact sameProfileDetails,so the level-routing logic was never actually exercised. Gave each level distinct data,
which caught
Product.getLoreLink/getVideoUrlhaving three branches that allreturned the same expression
LocalStorageWelcomeSurveyRepository.getSurvey()could never readlocalStorage: itscache started at
{survey: null}instead of unset, so the guard meant to skip aredundant read always won and the actual read was unreachable
TanstackStoreWelcomeSurvey.repository.tstouchedlocalStorageat import time withno guard, which would crash under a Node server-side render, coming later in this
stack. Guarded both accesses and added coverage proving it now imports fine without a
DOM
Test plan
pnpm typecheckpnpm checkpnpm buildpnpm test, 12 files, 70 tests, all green🤖 Generated with Claude Code
https://claude.ai/code/session_014BcGPRc3sgUJYKihGRXh5g